Re: [PATCH] t/t7601: Modernize test scripts using functions

From: Dorcas Litunya <anonolitunya@gmail.com>
Date: Oct 18, 2023, 12:52 UTC
Message-ID: <ZS/U+rPzVCpzGMww@dorcaslitunya-virtual-machine>
In-Reply-To: <xmqqjzrlgftp.fsf@gitster.g>

On Tue, Oct 17, 2023 at 01:21:54PM -0700, Junio C Hamano wrote:

Show 9 quoted lines

> Dorcas Litunya <anonolitunya@gmail.com> writes:
> 
> > Bcc: 
> > Subject: Re: [PATCH] t/t7601: Modernize test scripts using functions
> > Reply-To: 
> > In-Reply-To: <xmqq1qdumrto.fsf@gitster.g>
> 
> What are these lines doing here?
>

Sorry, I formatted the email wrongly.

Show 12 quoted lines

> > So should I replace this in the next version or leave this as is?
> 
> Perhaps I was not clear enough, but I found the commit title and
> description need to be updated to clearly record the intent of the
> change with a handful of points, so I will not be accepting the
> patch as-is.
> 
> These two sections may be of help.
> 
> Documentation/MyFirstContribution.txt::now-what
> Documentation/MyFirstContribution.txt::reviewing
>

Thanks for the resources and feedback. Ihave edited the patch based on it and sent v2.

> Thanks.