git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] var: avoid a segmentation fault when `HOME` is unset

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Sep 4, 2023, 20:26 UTC
Message-ID
<ZPY9j0XDt/VVMnhG@tapette.crustytoothpaste.net>
In-Reply-To
<pull.1580.git.1693808487058.gitgitgadget@gmail.com>
On 2023-09-04 at 06:21:26, Johannes Schindelin via GitGitGadget wrote:
Show 11 quoted lines
> From: Johannes Schindelin <johannes.schindelin@gmx.de>
> 
> The code introduced in 576a37fccbf (var: add attributes files locations,
> 2023-06-27) paid careful attention to use `xstrdup()` for pointers known
> never to be `NULL`, and `xstrdup_or_null()` otherwise.
> 
> One spot was missed, though: `git_attr_global_file()` can return `NULL`,
> when the `HOME` variable is not set (and neither `XDG_CONFIG_HOME`), a
> scenario not too uncommon in certain server scenarios.
> 
> Fix this, and add a test case to avoid future regressions.

Looks good to me. Thanks for the patch, and my apologies for the oversight.

-- 
brian m. carlson (he/him or they/them)
Toronto, Ontario, CA
Previous: Johannes Schindelin via GitGitGadgetNext: Johannes Schindelin
Message 2 of 3 in “var: avoid a segmentation fault when `HOME` is unset”
  1. var: avoid a segmentation fault when `HOME` is unsetJohannes Schindelin via GitGitGadget, Sep 4, 2023
  2. brian m. carlsonSep 4, 2023
  3. Johannes SchindelinSep 5, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.