Re: tb/commit-graph-tests (was: Re: What's cooking in git.git (Jul 2023, #06; Thu, 27))

From: Taylor Blau <me@ttaylorr.com>
Date: Aug 1, 2023, 20:50 UTC
Message-ID: <ZMlwGJv8GgIPBgQG@nand.local>
In-Reply-To: <CAPig+cTRUac+FRg6V1H+3_rusT17imQGZOy8Fd-MWriEv_epRQ@mail.gmail.com>

On Tue, Aug 01, 2023 at 02:33:23PM -0400, Eric Sunshine wrote:

Show 18 quoted lines

> On Mon, Jul 31, 2023 at 12:55 PM Taylor Blau <me@ttaylorr.com> wrote:
> > On Thu, Jul 27, 2023 at 06:46:42PM -0700, Junio C Hamano wrote:
> > > * tb/commit-graph-tests (2023-07-24) 5 commits
> > >  Test updates.
> > >
> > >  Will merge to 'next'?
> > >  source: <cover.1690216758.git.me@ttaylorr.com>
> >
> > I think this one is ready to go. Eric Sunshine gave the earlier round a
> > review, and I made sure to address his feedback in the subsequent
> > version.
> >
> > I'm happy to wait for an ACK from him, but I think this is low-risk
> > enough that you could merge it as-is. Either way :-).
>
> Yup, as I recall, I gave v1 a reasonably thorough read. When the
> reroll arrived, I scanned the range-diff and saw that the few minor
> review comments had been addressed, thus I had nothing more to add.

Thanks for giving it another look. In the latest WC, this is marked as "will merge to 'master'", so I think that we are good here.

Thanks, Taylor