Re: [PATCH] rerere: match the hash algorithm with its length

> "brian m. carlson" <sandals@crustytoothpaste.net> writes:
> 
> > I agree consistency here is a good idea.  However, I should point out
> > the definition of `get_sha1_hex`:
> >
> > int get_sha1_hex(const char *hex, unsigned char *sha1)
> > {
> > 	return get_hash_hex_algop(hex, sha1, the_hash_algo);
> > }
> 
> Yeah, I think I lifted the inlining from there, and you are
> absolutely right.  I think the main source of the confusion is that
> get_sha1_hex(), while it was a perfectly good name before the
> "struct object_id" world, has now become a misnomer.
> 
> I'd retract the patch you reviewed, but now I wonder if the
> following is a good idea.