git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Add 'preserve' subcommand to 'git stash'

From
Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Date
Jun 17, 2023, 08:39 UTC
Message-ID
<ZI1xLwemOs9Vxorf@ugly>
In-Reply-To
<xmqqv8fnrwtt.fsf@gitster.g>
On Fri, Jun 16, 2023 at 01:11:58PM -0700, Junio C Hamano wrote:
Show 14 quoted lines
>Oswald Buddenhagen <oswald.buddenhagen@gmx.de> writes:
>
>>>Why a new subcommand, not a new option to "push"?  Adding a new
>>>subcommand would mean it would be another unfamiliar thing users
>>>need to learn, as opposed to a slight variation of what they are
>>>already familiar with.
>>>
>> to be fair, there's also `apply` and not `pop --keep`.
>
>I do not care all that much if that is fair, but I do not think it
>is a meaningful comparison.  "stash apply" is merely exposing the
>first half (the other half is "stash drop") of a two step operation
>that is "stash pop".
>

i may be totally wrong about it (because i don't understand the motivation behind this feature, either), but i think the _intent_ of nadav's patch is to merely expose the first half of "stash push" (the other half is the implicit "reset --hard"). it may not be a sufficiently good one, but there is clearly an analogy here.

regards, ossi

Previous: Junio C HamanoNext: Junio C Hamano
Message 5 of 10 in “Add 'preserve' subcommand to 'git stash'”
  1. Add 'preserve' subcommand to 'git stash'Nadav Goldstein via GitGitGadget, Jun 16, 2023
  2. Junio C HamanoJun 16, 2023
  3. Oswald BuddenhagenJun 16, 2023
  4. Junio C HamanoJun 16, 2023
  5. Oswald BuddenhagenJun 17, 2023
  6. Junio C HamanoJun 17, 2023
  7. Nadav GoldsteinJun 18, 2023
  8. Oswald BuddenhagenJun 18, 2023
  9. Nadav GoldsteinJun 18, 2023
  10. Junio C HamanoJun 19, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.