Re: Changed path filter hash differs from murmur3 if char is signed
- From
Taylor Blau <me@ttaylorr.com>
- Date
- May 12, 2023, 21:27 UTC
- Message-ID
- <ZF6vW7/BhKqUyP7R@nand.local>
- In-Reply-To
- <20230512205427.1090937-1-jonathantanmy@google.com>
On Fri, May 12, 2023 at 01:54:27PM -0700, Jonathan Tan wrote:
Show 11 quoted lines
> > > I don't have statistics on this, but if the majority of repos have > > > only <=0x7f filenames (which seems reasonable to me), this might save > > > sufficient work that we can proceed with bumping the version number and > > > ignoring old data. > > > > > >> Better yet, we should be able to reuse existing Bloom filter data for > > >> paths that have all characters <=0xff, and only recompute them where > > > > "ff" -> "7f" I presume? > > That was my assumption too, but Taylor can clarify.
Sorry, yes, I meant "0x7f" here not "0xff". Thanks for catching, both.
Thanks, Taylor