tb/ban-strtok (was: Re: What's cooking in git.git (Apr 2023, #07; Tue, 25))

From: Taylor Blau <me@ttaylorr.com>
Date: Apr 26, 2023, 23:34 UTC
Message-ID: <ZEm1F78kF7rMWyFb@nand.local>
In-Reply-To: <xmqq354nxzqr.fsf@gitster.g>

On Tue, Apr 25, 2023 at 05:18:20PM -0700, Junio C Hamano wrote:

Show 10 quoted lines

> * tb/ban-strtok (2023-04-24) 6 commits
>  - banned.h: mark `strtok()` and `strtok_r()` as banned
>  - t/helper/test-json-writer.c: avoid using `strtok()`
>  - t/helper/test-oidmap.c: avoid using `strtok()`
>  - t/helper/test-hashmap.c: avoid using `strtok()`
>  - string-list: introduce `string_list_setlen()`
>  - string-list: multi-delimiter `string_list_split_in_place()`
>
>  Mark strtok() and strtok_r() to be banned.
>  source: <cover.1682374789.git.me@ttaylorr.com>

This one is ready to go. Peff took a look[1] over the latest version and I think we both agree it's in a good place.

Thanks, Taylor

[1]: https://lore.kernel.org/git/20230425062708.GC4061254@coredump.intra.peff.net/