Re: Add a way to disable «git clean» per repo

From: Guillem Jover <guillem@hadrons.org>
Date: Apr 9, 2023, 17:01 UTC
Message-ID: <ZDLvUxp0d33VgFQY@thunder.hadrons.org>
In-Reply-To: <xmqq355g6f6u.fsf@gitster.g>

Hi!

On Mon, 2023-04-03 at 10:36:25 -0700, Junio C Hamano wrote:

Show 5 quoted lines

> Guillem Jover <guillem@hadrons.org> writes:
> > Accidentally running «git clean -xdf» or «git clean -Xdf» might be
> > catastrophic there.
> 
> So would accidentally running "rm -fr" there be catastrophic, too.

Sure.

> I doubt it would make much sense to file a feature request to Debian
> or GNU/FSF to disable "rm -r" in certain directories.  I am not sure
> why "git clean" should be any different.

Right, but I see a substantial difference though, «git clean» is part of the git toolset to manage among other things specific work trees, where that behavior is controlled through configuration, and is as such confined within those specific realms, where also the properties of what is being tracked might be different. (With GNU coreutils rm you can confine it within one filesystem with --one-file-system, but TBH I've never had the need to use it AFAIR, and it's not enabled by default.)

> Commands like "git clean" require "-f" before they become overly
> destructuve for a reason.  clean.requireForce defaults to true for
> the same reason.

Right, I guess that's another reason for me why I see these («rm» vs «git clean») as not being entirely comparable. Using «rm» requires in most cases no force options, even when removing recursively (with -r), while «git clean» by default will fail fatally (for all invocations AFAICS?), so perhaps I'm holding it wrong, but when you end up invoking a command very often (f.ex. to make sure your project is building from a clean state), which requires using a force option (because passing -i would become very cumbersome very quick), that becomes a habit or part of your muscle-memory (perhaps a bad one), that means I tend to not pay as much attention as I'd do when running «rm -rf» (also because of the confinement I mentioned above).

For now it occurred to me that I could create dummy git repos in parent directories to act as «git clean» barriers, so that it does not propagate further up in the directory tree, but that still seems like a hack, and I'd really like to protect specific work trees where I know I never want to be able to run «git clean».

Thanks, Guillem