[PATCH 2/4] http: drop unused parameter from start_object_request()
- From
Jeff King <peff@peff.net>
- Date
- Mar 17, 2023, 19:16 UTC
- Message-ID
- <ZBS8kqjaq2DIZMEG@coredump.intra.peff.net>
- In-Reply-To
- <ZBS77VYL9ZrxKtCN@coredump.intra.peff.net>
We take a "walker" parameter for the request, but don't actually look at it. This is due to 5424bc557f (http*: add helper methods for fetching objects (loose), 2009-06-06). Before then, we consulted the "walker" struct to tell us if we should be verbose, but now those messages are printed elsewhere.
Let's drop the unused parameter to make -Wunused-parameter happy.
Signed-off-by: Jeff King <peff@peff.net> --- http-walker.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/http-walker.c b/http-walker.c index b8f0f98ae14..6b9bdb529b5 100644 --- a/http-walker.c +++ b/http-walker.c @@ -52,8 +52,7 @@ static void fetch_alternates(struct walker *walker, const char *base); static void process_object_response(void *callback_data); -static void start_object_request(struct walker *walker, - struct object_request *obj_req) +static void start_object_request(struct object_request *obj_req) { struct active_request_slot *slot; struct http_object_request *req; @@ -110,7 +109,7 @@ static void process_object_response(void *callback_data) obj_req->repo = obj_req->repo->next; release_http_object_request(obj_req->req); - start_object_request(walker, obj_req); + start_object_request(obj_req); return; } } @@ -138,7 +137,7 @@ static int fill_active_slot(struct walker *walker) if (has_object_file(&obj_req->oid)) obj_req->state = COMPLETE; else { - start_object_request(walker, obj_req); + start_object_request(obj_req); return 1; } }
-- 2.40.0.581.g8d688c70eca