Re: [GSoC PATCH v5 0/3] reftable: return proper error codes from block_writer_add

From: Patrick Steinhardt <ps@pks.im>
Date: Mar 19, 2025, 15:48 UTC
Message-ID: <Z9rnZzbEasyRbHIY@pks.im>
In-Reply-To: <20250319152927.1263033-1-meetsoni3017@gmail.com>

On Wed, Mar 19, 2025 at 08:59:24PM +0530, Meet Soni wrote:

Show 6 quoted lines

> This patch series attempts to avoid making an assumption regarding error codes
> returned by block_writer_add().
> 
> Changes since v4:
>     - update commit message.
>     - add documentation comment.

One additional change that isn't mentioned here is that we now check for REFTABLE_ENTRY_TOO_BIG_ERROR the second time we call `block_writer_add()` when writing object records, which is what my only concern was. So with that now addressed I'm happy with this patch series, thanks for working on it!

Patrick

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.