Re: [PATCH] index-pack, unpack-objects: restore missing ->init_fn

From: Patrick Steinhardt <ps@pks.im>
Date: Mar 19, 2025, 09:32 UTC
Message-ID: <Z9qPMvclpdEIjQ3l@pks.im>
In-Reply-To: <20250318111616.113941-1-hmz007@gmail.com>

On Tue, Mar 18, 2025 at 07:16:10PM +0800, Jensen Huang wrote:

Show 5 quoted lines

> Commit 0578f1e66a ("global: adapt callers to use generic hash context helpers")
> accidentally removed `->init_fn`, which is required for OpenSSL 3+ SHA1.
> 
> This fixes the following error on fetch:
>   fatal: fetch-pack: invalid index-pack output

The change makes sense indeed. I do wonder though: can we maybe improve `git_hash_clone()` so that it is not required to initialize the context beforehand?

Thanks!

Patrick