Re: What's cooking in git.git (Mar 2025, #03; Wed, 12)

From: Taylor Blau <me@ttaylorr.com>
Date: Mar 17, 2025, 22:39 UTC
Message-ID: <Z9iksBa4g2bUkX1u@nand.local>
In-Reply-To: <xmqqh63xx23f.fsf@gitster.g>

On Wed, Mar 12, 2025 at 04:26:28PM -0700, Junio C Hamano wrote:

Show 12 quoted lines

> * tb/multi-cruft-pack-refresh-fix (2025-03-11) 6 commits
>  - builtin/pack-objects.c: freshen objects from existing cruft packs
>  - builtin/repack.c: simplify cruft pack aggregation
>  - pack-objects: generate cruft packs at most one object over threshold
>  - t/lib-cruft.sh: extract some cruft-related helpers
>  - t7704-repack-cruft.sh: consolidate `write_blob()`
>  - t/t5329-pack-objects-cruft.sh: evict 'repack'-related tests
>
>  Certain "cruft" objects would have never been refreshed when there
>  are multiple cruft packs in the repository, which has been
>  corrected.
>  source: <cover.1741648467.git.me@ttaylorr.com>

This one can be replaced with "v5" of this topic, which only fixes the freshening bug, and punts on the --max-pack-size versus --combine-cruft-below-size debacle.

I'll send a separate series to address the latter shortly.

Show 22 quoted lines

> * tb/incremental-midx-part-2 (2024-11-20) 15 commits
>  - midx: implement writing incremental MIDX bitmaps
>  - pack-bitmap.c: use `ewah_or_iterator` for type bitmap iterators
>  - pack-bitmap.c: keep track of each layer's type bitmaps
>  - ewah: implement `struct ewah_or_iterator`
>  - pack-bitmap.c: apply pseudo-merge commits with incremental MIDXs
>  - pack-bitmap.c: compute disk-usage with incremental MIDXs
>  - pack-bitmap.c: teach `rev-list --test-bitmap` about incremental MIDXs
>  - pack-bitmap.c: support bitmap pack-reuse with incremental MIDXs
>  - pack-bitmap.c: teach `show_objects_for_type()` about incremental MIDXs
>  - pack-bitmap.c: teach `bitmap_for_commit()` about incremental MIDXs
>  - pack-bitmap.c: open and store incremental bitmap layers
>  - pack-revindex: prepare for incremental MIDX bitmaps
>  - Documentation: describe incremental MIDX bitmaps
>  - Merge branch 'tb/pseudo-merge-bitmap-fixes' into tb/incremental-midx-part-2
>  - Merge branch 'tb/incremental-midx-part-1' into tb/incremental-midx-part-2
>
>  Incrementally updating multi-pack index files.
>
>  Expecting a (hopefully minor and final) reroll.
>  cf. <Z8JSreTnEFlocYQ9@nand.local> <Z8JLbxBQh7XUpplz@nand.local>
>  source: <cover.1732054032.git.me@ttaylorr.com>

Thanks. This is rerolled, but it would be good to get some review from others that are familiar with bitmaps before merging. It's not a very long series by lines of code, but it is rather subtle, so the more careful reviews it gets the better.

Thanks, Taylor