Re: [PATCH v2 0/3] Add a static analysis job to prevent assertions with side effects

From: Taylor Blau <me@ttaylorr.com>
Date: Mar 17, 2025, 22:34 UTC
Message-ID: <Z9ijYliQPX7PI/0h@nand.local>
In-Reply-To: <pull.1881.v2.git.1742107322.gitgitgadget@gmail.com>

On Sun, Mar 16, 2025 at 06:41:59AM +0000, Elijah Newren via GitGitGadget wrote:

> Elijah Newren (3):
>   git-compat-util: introduce BUG_IF_NOT() macro
>   ci: add build checking for side-effects in assert() calls
>   treewide: replace assert() with BUG_IF_NOT() in special cases

Nice, this version looks great to me. I left a couple of notes throughout, but they range from "could be done later" to idle commentary. Thanks for working on this, and I'm sorry to have sent you down such a rabbit hole ;-).

    Reviewed-by: Taylor Blau <me@ttaylorr.com>

Thanks, Taylor

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.