git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/2] Ensure zlib version is printed by git-version(1)

From
Patrick Steinhardt <ps@pks.im>
Date
Mar 7, 2025, 14:20 UTC
Message-ID
<Z8sAwLHff3S4jF1P@pks.im>
In-Reply-To
<20250307-toon-zlib-git-version-v1-0-5e8069752bb9@iotcl.com>
On Fri, Mar 07, 2025 at 03:18:06PM +0100, Toon Claes wrote:
Show 12 quoted lines
> I was trying to benchmark the difference between using zlib and zlib-ng.
> To be sure I was testing the correct version, I was interested if
> git-version(1) would tell which zlib library it uses. After some digging
> I saw it should be printing the zlib version number, but on my machine
> it wasn't.
> 
> I discovered a regression caused by 41f1a8435a (git-compat-util: move
> include of "compat/zlib.h" into "git-zlib.h", 2025-01-28). In the first
> commit I'm addressing that regression.
> 
> But I've noticed building against zlib-ng directly still didn't print
> the zlib version. This issue is resolved in the second commit.

I've already reviewed the change internally and it looked obviously good to me. Thanks for finding, fixing and improving this!

Patrick
Previous: Toon ClaesNext: Junio C Hamano
Message 5 of 6 in “Ensure zlib version is printed by git-version(1)”
  1. 0/2 Ensure zlib version is printed by git-version(1)Toon Claes, Mar 7, 2025
  2. 1/2 help: include git-zlib.h to print zlib versionToon Claes, Mar 7, 2025
  3. Junio C HamanoMar 7, 2025
  4. 2/2 help: print zlib-ng version numberToon Claes, Mar 7, 2025
  5. Patrick SteinhardtMar 7, 2025
  6. Junio C HamanoMar 7, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.