Re: [PATCH 09/12] gitk: extract script to build Gitk

From: Patrick Steinhardt <ps@pks.im>
Date: Feb 19, 2025, 05:53 UTC
Message-ID: <Z7Vxx_yQSMlXfteX@pks.im>
In-Reply-To: <xmqqeczuj3fc.fsf@gitster.g>

On Tue, Feb 18, 2025 at 02:25:43PM -0800, Junio C Hamano wrote:

Show 13 quoted lines

> Patrick Steinhardt <ps@pks.im> writes:
> 
> > Extract the script that "builds" Gitk from our Makefile so that we can
> > reuse it in Meson.
> >
> > Signed-off-by: Patrick Steinhardt <ps@pks.im>
> > ---
> >  gitk-git/Makefile        |  7 +++----
> >  gitk-git/generate-tcl.sh | 11 +++++++++++
> >  2 files changed, 14 insertions(+), 4 deletions(-)
> 
> You would want to coordinate this with Johannes Sixt, who may still
> want to maintain the subtree arrangement.

Oh, I had him in mind when writing the patch series, but thought that he only maintained git-gui, not gitk. Must have been misremembering.

Anyway, Johannes, I'm happy to evict these changes from this patch series and create them as a pull request against your tree. We should then also be including the project as a `subproject()` so that it can be used standalone.

Patrick