Re: [PATCH v2 1/5] merge-tree --stdin: flush stdout to avoid deadlock
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Feb 19, 2025, 06:23 UTC
- Message-ID
- <Z7V48_q3Uu9d0D3Q@pks.im>
- In-Reply-To
- <3b3179785098580f3336bb24bdbaf0aa1366bfcd.1739895879.git.gitgitgadget@gmail.com>
On Tue, Feb 18, 2025 at 04:24:35PM +0000, Phillip Wood via GitGitGadget wrote:
Show 20 quoted lines
> diff --git a/builtin/merge-tree.c b/builtin/merge-tree.c
> index 9a6c8b4e4cf..57f4340faba 100644
> --- a/builtin/merge-tree.c
> +++ b/builtin/merge-tree.c
> @@ -18,6 +18,7 @@
> #include "tree.h"
> #include "config.h"
> #include "strvec.h"
> +#include "write-or-die.h"
>
> static int line_termination = '\n';
>
> @@ -623,6 +624,7 @@ int cmd_merge_tree(int argc,
> } else {
> die(_("malformed input line: '%s'."), buf.buf);
> }
> + maybe_flush_or_die(stdout, "stdout");
>
> if (result < 0)
> die(_("merging cannot continue; got unclean result of %d"), result);I was briefly wondering whether we should rather move this into `real_merge()` itself, which is responsible for writing to stdout. But the only other callsite doesn't really care as it will exit immediately anyway. So this is probably fine.
Overall the series looks good to me, thanks!
Patrick