Re: [PATCH v2] doc(send-email): use correct name of the --signed-off-by-cc in git send-email doc

From: Patrick Steinhardt <ps@pks.im>
Date: Feb 18, 2025, 11:22 UTC
Message-ID: <Z7RtXXsDRxuEqCgC@pks.im>
In-Reply-To: <20250218085913.1381537-1-mcepl@cepl.eu>

On Tue, Feb 18, 2025 at 09:58:38AM +0100, Matěj Cepl wrote:

Show 6 quoted lines

> I don’t think there is an option --signed-off-cc (without -by)
> for git send-email.
> 
> Signed-off-by: Matěj Cepl <mcepl@cepl.eu>
> ---
> Rebase on the top of the current master (Whoops!) and improve the commit message.

It's better, but still not quite there:

  - The subject now uses `doc(send-email)`, which is an idiom we don't
    use over here.

  - The commit message still doesn't use imperative mood.

I know, we're quite pedantic about commit messages over here, but please bear with us :) How about this instead:

    docs: fix misspelled `--no-signed-off-by-cc` in git-send-email(1)

    In git-send-email(1) we reference the `--no-signed-off-cc` command
    line argument. This argument does not exist and never has existed,
    but it is an obvious misspelling of `--no-signed-off-by-cc`.

    Fix the misspelled argument.

    Signed-off-by: ...

It would also be great if you send future revisions of a patch series in the same thread. You can do so via `--in-reply-to`, where the parameter is the message ID of the first message of the first version of your patch series.

Thanks!

Patrick