git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: win+Meson test failures due to ps/build-meson-fixes-0130 topic?

From
Patrick Steinhardt <ps@pks.im>
Date
Feb 26, 2025, 16:29 UTC
Message-ID
<Z79BVcFMdCpgbKqM@pks.im>
In-Reply-To
<xmqqh64gg0pu.fsf@gitster.g>
On Wed, Feb 26, 2025 at 07:55:09AM -0800, Junio C Hamano wrote:
Show 17 quoted lines
> Patrick Steinhardt <ps@pks.im> writes:
> 
> > Okay, the issue was in 163a3e97ac1 (meson: simplify use of the
> > common-main library, 2025-01-30). In that commit we stopped using the
> > common-main dependency for a couple of binaries, including
> > git-remote-https and others. What I didn't realize though is that this
> > also made us not use the linker arguments anymore, but those are
> > required on Windows when linking an executable.
> >
> > I've kicked off CI jobs on GitHub to verify that the revised version of
> > this patch series works alright. Once those tests pass I'll send another
> > version of this patch series.
> 
> Thanks.  What is a bit more worrying is that you earlier said your
> other CI didn't notice anything funny.  Is the reason for the
> non-breakage also known (like: the two CI jobs build things
> differently)?

Oh, yeah, I forgot to mention that detail: the jobs failed, but the failure wasn't reported (see e.g. [1]). It's a bug in the CI setup itself. I'll send a patch series tomorrow to fix that.

Patrick
[1]: https://gitlab.com/gitlab-org/git/-/jobs/8996075448
Previous: Junio C Hamano
Message 10 of 10 in “win+Meson test failures due to ps/build-meson-fixes-0130 topic?”
  1. Junio C HamanoFeb 25, 2025
  2. Patrick SteinhardtFeb 26, 2025
  3. Jeff KingFeb 26, 2025
  4. Patrick SteinhardtFeb 26, 2025
  5. Jeff KingFeb 26, 2025
  6. Jeff KingFeb 26, 2025
  7. Patrick SteinhardtFeb 26, 2025
  8. Jeff KingFeb 26, 2025
  9. Junio C HamanoFeb 26, 2025
  10. Patrick SteinhardtFeb 26, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.