git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [GSoC][PATCH] t7603: replace test -f by test_path_is_file

From
Patrick Steinhardt <ps@pks.im>
Date
Feb 10, 2025, 06:48 UTC
Message-ID
<Z6mhU50bt5iYVuZ8@pks.im>
In-Reply-To
<20250208165731.78804-1-lucasseikioshiro@gmail.com>
On Sat, Feb 08, 2025 at 01:57:31PM -0300, Lucas Oshiro wrote:
> `test_path_is_file` provides a better output when asserting whether a
> file exists. Replace the occurrences of `test -f` in 7603 by it,

Tiny nit, which probably does not warrant a reroll: it would be nice to consistently refer to test suites with the "t" prefix, so here you'd say "t7603" instead of just "7603".

The changes themselv look good to me, thanks!
Patrick
Previous: Lucas Oshiro
Message 2 of 2 in “t7603: replace test -f by test_path_is_file”
  1. Lucas OshiroFeb 8, 2025
  2. Patrick SteinhardtFeb 10, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.