Re: [PATCH v3 1/5] refactor(remote): rename function omit_name_by_refspec

From: Patrick Steinhardt <ps@pks.im>
Date: Feb 3, 2025, 06:45 UTC
Message-ID: <Z6BmIGIJYq5D2ZWO@pks.im>
In-Reply-To: <20250201064202.76116-2-meetsoni3017@gmail.com>

On Sat, Feb 01, 2025 at 12:11:58PM +0530, Meet Soni wrote:

Please drop the `refactor()` bit from the commit subject, we don't use these prefixes here. You also did the same in a later commit.

Show 6 quoted lines

> Rename the function `omit_name_by_refspec()` to
> `refname_matches_negative_refspec_item()` to provide clearer intent.
> The previous function name was vague and did not accurately describe its
> purpose. By using `refname_matches_negative_refspec_item`, make the
> function's purpose more intuitive, clarifying that it checks if a
> reference name matches any negative refspec.

The new name certainly reads way better, and the changes themselves look

Patrick

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.