Re: [PATCH v4 1/8] t5504: modernize test by moving heredocs into test bodies
On Fri, Jan 31, 2025 at 09:28:01AM -0500, Eric Sunshine wrote:
Show 25 quoted lines
> On Fri, Jan 31, 2025 at 5:53 AM Patrick Steinhardt <ps@pks.im> wrote:
> > We have several heredocs in t5504 located outside of any particular test
> > bodies. Move these into the test bodies to match our modern coding
> > style.
> >
> > Signed-off-by: Patrick Steinhardt <ps@pks.im>
> > ---
> > diff --git a/t/t5504-fetch-receive-strict.sh b/t/t5504-fetch-receive-strict.sh
> > @@ -64,12 +64,6 @@ test_expect_success 'fetch with transfer.fsckobjects' '
> > -cat >exp <<EOF
> > -To dst
> > -! refs/heads/main:refs/heads/test [remote rejected] (missing necessary objects)
> > -Done
> > -EOF
> > -
> > test_expect_success 'push without strict' '
> > @@ -78,6 +72,11 @@ test_expect_success 'push without strict' '
> > + cat >exp <<-EOF &&
> > + To dst
> > + ! refs/heads/main:refs/heads/test [remote rejected] (missing necessary objects)
> > + Done
> > + EOF
>
> It's minor, but to make this conform to modern style even more, it
> would use `\EOF` rather than `EOF`.
Yup, indeed. Will fix, thanks for your review!
Patrick