Re: [PATCH 0/3] setup: fix reinit of repos with different formats

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Jan 30, 2025, 23:58 UTC
Message-ID: <Z5wSEBZJU0qebKYY@tapette.crustytoothpaste.net>
In-Reply-To: <20250130-b4-pks-reinit-default-ref-format-v1-0-d2769ca01207@pks.im>

On 2025-01-30 at 16:24:16, Patrick Steinhardt wrote:

Show 7 quoted lines

> Hi,
> 
> this issue with the reinitialization of the ref format was recently
> discovered in our CI systems at GitLab, where caches contained repos
> with one ref format but we tried to reinit them with a different ref
> format. But turns out that the same issue also exists for the object
> format, so this patch series fixes both issues.

I looked at this series and it seems reasonable. As you mentioned, reinitializing the repository in this way cannot possibly work in any meaningful sense, so rejecting it is the prudent thing to do.

-- 
brian m. carlson (they/them or he/him)
Toronto, Ontario, CA