Re: [PATCH v3 2/4] date.c: Fix type conversation warnings from msvc
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Jan 27, 2025, 07:26 UTC
- Message-ID
- <Z5c1F7oqsaPrHRiT@pks.im>
- In-Reply-To
- <20250126125850.3195-1-soekkle@freenet.de>
On Sun, Jan 26, 2025 at 01:58:50PM +0100, Sören Krecker wrote:
Show 5 quoted lines
> Fix compiler warnings from msvc in date.c for value truncation from 64 > bit to 32 bit integers. > > Also switch from int to size_t for all variables with result of strlen() > which cannot become negative.
As far as I can see this patch only does the latter and doesn't do the former, so the commit message seems inaccurate to me.
Show 12 quoted lines
> diff --git a/date.c b/date.c
> index a1b26a8dce..0a3fafc8a4 100644
> --- a/date.c
> +++ b/date.c
> @@ -1270,8 +1270,8 @@ static const char *approxidate_alpha(const char *date, struct tm *tm, struct tm
>
> tl = typelen;
> while (tl->type) {
> - int len = strlen(tl->type);
> - if (match_string(date, tl->type) >= len-1) {
> + size_t len = strlen(tl->type);
> + if (match_string(date, tl->type)+1 >= len) {Formatting is off here, there should be spaces around `+`, even though you simply followed previous style. It would be nice to point out why this change is makde in the commit message.
Patrick