git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] meson: fix perl dependencies for Documentation

From
Patrick Steinhardt <ps@pks.im>
Date
Jan 14, 2025, 14:26 UTC
Message-ID
<Z4Z0Fxj87XrqdZl7@pks.im>
In-Reply-To
<5114dc9a00377826a55f6bab007d2ad1a4de8bc5.1736863427.git.sam@gentoo.org>
On Tue, Jan 14, 2025 at 02:03:47PM +0000, Sam James wrote:
Show 25 quoted lines
> We need an explicit `depends: documentation_deps` so that all of our
> Documentation targets know they require asciidoc.conf. This shows up
> as parallel build failures with it not yet being available.
> 
> Other targets look OK already.
> 
> Signed-off-by: Sam James <sam@gentoo.org>
> ---
> v2: Drop incorrect dep I'd added for api-index.sh as pointed out by Patrick.
> 
>  Documentation/technical/meson.build | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/technical/meson.build b/Documentation/technical/meson.build
> index 21dfb8b5c9..3a65ee59b3 100644
> --- a/Documentation/technical/meson.build
> +++ b/Documentation/technical/meson.build
> @@ -60,6 +60,7 @@ foreach article : api_docs + articles
>      command: asciidoc_html_options,
>      input: article,
>      output: fs.stem(article) + '.html',
> +    depends: documentation_deps,
>      install: true,
>      install_dir: get_option('datadir') / 'doc/git-doc/technical',
>    )

Okay, this looks good to me now, thanks. One last nit on the subject though: as far as I can see the change doesn't have anything to do with Perl, so it is somewhat confusing. How about:

   meson: fix missing deps for technical articles
Thanks!
Patrick
Previous: Sam JamesNext: Sam James
Message 2 of 3 in “meson: fix perl dependencies for Documentation”
  1. meson: fix perl dependencies for DocumentationSam James, Jan 14, 2025
  2. Patrick SteinhardtJan 14, 2025
  3. Sam JamesJan 14, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.