Re: [PATCH v2 11/12] t/Makefile: make "check-meson" work with Dash

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jan 2, 2025, 15:37 UTC
Message-ID: <Z3ayzUEfW1xd4Up0@google.com>
In-Reply-To: <20241227-b4-pks-meson-docs-v2-11-f61e63edbfa1@pks.im>

Hi,

Patrick Steinhardt wrote:

Show 12 quoted lines

> The "check-meson" target uses process substitution to check whether
> extracted contents from "meson.build" match expected contents. Process
> substitution is unportable though and thus the target will fail when
> using for example Dash.
>
> Fix this by writing data into a temporary directory.
>
> Signed-off-by: Patrick Steinhardt <ps@pks.im>
> ---
>  t/.gitignore |  1 +
>  t/Makefile   | 12 +++++++-----
>  2 files changed, 8 insertions(+), 5 deletions(-)

Without this, I get the error described in https://lore.kernel.org/git/CAHWeT-boK3x6mup11boEinNDQiAxxf0vwvZkxsGRc_GRvXYA8g@mail.gmail.com/ ('/bin/sh: 10: Syntax error: "(" unexpected'), and with this, the build in the Debian buildd environment succeeds.

Tested-by: Jonathan Nieder <jrnieder@gmail.com>

Thanks for fixing it.

Sincerely, Jonathan