Re: [PATCH 1/8] ci/lib: support custom output directories when creating test artifacts

From: Patrick Steinhardt <ps@pks.im>
Date: Dec 13, 2024, 05:24 UTC
Message-ID: <Z1vFKSPMvLNFqBCK@pks.im>
In-Reply-To: <CAOLa=ZTtkM_unYCjgQf0FZCo=4KOmOiRosC8jPOcs_Np+tCd-g@mail.gmail.com>

On Thu, Dec 12, 2024 at 02:16:30AM -0800, karthik nayak wrote:

Show 10 quoted lines

> Patrick Steinhardt <ps@pks.im> writes:
> 
> > Update `create_failed_test_artifacts ()` so that it can handle arbitrary
> > test output directories. This fixes creation of these artifacts for
> > macOS on GitLab CI, which uses a separate output directory already. This
> > will also be used by our out-of-tree builds with Meson.
> >
> 
> So currently in the config: `TEST_OUTPUT_DIRECTORY: "/Volumes/RAMDisk"`.
> So this is broken as is?

Yeah. I've noticed multiple times that the test output directory is not uploaded on failing macOS jobs.

Patrick

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.