Re: [PATCH] object-name: fix reversed ordering with magic pathspecs

From: Patrick Steinhardt <ps@pks.im>
Date: Dec 6, 2024, 12:25 UTC
Message-ID: <Z1LtS-8f8WZyobz3@pks.im>
In-Reply-To: <9c7b9090-8cf2-4095-8e86-2c85b6fe407f@app.fastmail.com>

On Fri, Dec 06, 2024 at 12:20:45PM +0100, Kristoffer Haugsbakk wrote:

Show 13 quoted lines

> > diff --git a/t/t4208-log-magic-pathspec.sh
> > b/t/t4208-log-magic-pathspec.sh
> 
> Yes, so here is that magic pathspec name.  But this test file has a lot
> of tests that test positional argument ambiguity.  Which seems very
> relevant to pathspecs in particular.  And revision selection syntax
> seems to be used to test how things are interpreted.  Not really how
> things are ultimately processed (that seems secondary).
> 
> The tests involving `:/` in particular seem to only be about
> ambiguity testing.
> 
> Is this the correct test file?

Probably not. I couldn't really find any cases where we explicitly verify this syntax, which explains why the regression was not found. I've added it to t1500 now, which is at least better than t4208.

Thanks!

Patrick