Re: [PATCH v2] advice: suggest using subcommand "git config set"

From: Patrick Steinhardt <ps@pks.im>
Date: Dec 6, 2024, 08:57 UTC
Message-ID: <Z1K8ZPF9eOqQYsqf@pks.im>
In-Reply-To: <20241205122225.1184215-1-bence@ferdinandy.com>

On Thu, Dec 05, 2024 at 01:21:58PM +0100, Bence Ferdinandy wrote:

Show 10 quoted lines

> The advice message currently suggests using "git config advice..." to
> disable advice messages, but since
> 
> 00bbdde141 (builtin/config: introduce "set" subcommand, 2024-05-06)
> 
> we have the "set" subcommand for config. Since using the subcommand is
> more in-line with the modern interface, any advice should be promoting
> its usage. Change the disable advice message to use the subcommand
> instead. Change all uses of "git config advice" in the tests to use the
> subcommand.

Thanks, this version looks good to me!

Patrick