Re: [PATCH v2] fast-import: disallow "." and ".." path components

From: Patrick Steinhardt <ps@pks.im>
Date: Nov 26, 2024, 06:57 UTC
Message-ID: <Z0Vxb4OVJYeAdgds@pks.im>
In-Reply-To: <pull.1831.v2.git.1732561248717.gitgitgadget@gmail.com>

On Mon, Nov 25, 2024 at 07:00:48PM +0000, Elijah Newren via GitGitGadget wrote:

Show 11 quoted lines

> From: Elijah Newren <newren@gmail.com>
> 
> If a user specified e.g.
>    M 100644 :1 ../some-file
> then fast-import previously would happily create a git history where
> there is a tree in the top-level directory named "..", and with a file
> inside that directory named "some-file".  The top-level ".." directory
> causes problems.  While git checkout will die with errors and fsck will
> report hasDotdot problems, the user is going to have problems trying to
> remove the problematic file.  Simply avoid creating this bad history in
> the first place.

Makes sense.

More generally this made me wonder whether we should maybe extract some bits out of "fsck.c" so that we don't have to duplicate the checks done there in git-fast-import(1). This would for example include checks for ".git" and its HFS/NTFS variants as well as tree entry length checks for names longer than 4096 characters.

This of course does not have to be part of your patch, which looks good to me.

Thanks!

Patrick