Re: [PATCH v2 12/14] builtin/patch-id: fix type of `get_one_patchid()`

From: Patrick Steinhardt <ps@pks.im>
Date: Dec 2, 2024, 13:24 UTC
Message-ID: <Z020838LPcl9jp_8@pks.im>
In-Reply-To: <Z02zq7Wc1A2ot-Oe@ArchLinux>

On Mon, Dec 02, 2024 at 09:18:35PM +0800, shejialuo wrote:

Show 10 quoted lines

> On Mon, Dec 02, 2024 at 01:04:44PM +0100, Patrick Steinhardt wrote:
> > In `get_one_patchid()` we assign either the result of `strlen()` or
> > `remove_space()` to `len`. But while the former correctly returns a
> > `size_t`, the latter returns an `int` to indicate the length of the
> 
> It is a little misleading about the statement "the latte returns an
> `int` to indicate the length of the string".
> 
> Should "without spaces" be appended into the last? However, don't worth
> a reroll.

I'll say "stripped string" to keep things short. I won't send a reroll just for this, but will send it out if there's going to be a v3 of this series.

Thanks!

Patrick

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.