Re: [PATCH 1/1] builtin/update-server-info: remove unnecessary if statement

From: Patrick Steinhardt <ps@pks.im>
Date: Mar 31, 2025, 07:16 UTC
Message-ID: <Z-pBXOxmtJu9a9R4@pks.im>
In-Reply-To: <20250329120327.105925-2-usmanakinyemi202@gmail.com>

On Sat, Mar 29, 2025 at 05:29:25PM +0530, Usman Akinyemi wrote:

> Since we already teach the `repo_config()` to allow `repo`
> to be NULL, no need to check if `repo` is NULL before calling
> `repo_config()`.

Tiny nit: when you refer to changes made in a previous commit it makes sense to reference that commit via `git log -1 --format=reference` so that outside readers who aren't deeply familiar with the recent changes know where to look.

Other than that this patch looks good to me, thanks!

Patrick