Re: [PATCH v2] tmp-objdir: skip clean up when handling a signal
On Tue, Sep 27, 2022 at 03:38:26PM -0400, Jeff King wrote:
Show 5 quoted lines
> > Since we can't do the cleanup in a portable and signal-safe way, skip
> > the cleanup when we're handling a signal.
>
> Thanks, this looks fine to me, though I think there are a few extra
> cleanup opportunities that could be squashed in:
> -static int tmp_objdir_destroy_1(struct tmp_objdir *t)
> +static int tmp_objdir_destroy(struct tmp_objdir *t)
Whoops, you'd obviously want to drop the "static" here, as well.
-Peff
Jeff King <peff@peff.net>