git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/3] midx: use `--stdin-packs` to implement `repack`

From
Jeff King <peff@peff.net>
Date
Sep 20, 2022, 21:54 UTC
Message-ID
<Yyo2mJZt6B0JVGwA@coredump.intra.peff.net>
In-Reply-To
<cover.1663706401.git.me@ttaylorr.com>
On Tue, Sep 20, 2022 at 04:40:14PM -0400, Taylor Blau wrote:
Show 9 quoted lines
> Here's a few patches that replace the existing "feed each OID
> one-by-one" approach to implement the `repack` sub-command of the
> `multi-pack-index` builtin with one that uses `pack-objects`'s
> `--stdin-packs` option.
> 
> There is an additional patch at the beginning of this series in order to
> extract the mtime-sorted list of packs to rollup from their home in
> `fill_included_packs_batch()`. There's also one more on the end to unify
> the `include_pack` array into the `repack_info` struct(s) themselves.
The first and third make sense to me, and it looks like a nice cleanup.

The middle one looks fine, modulo all of our earlier discussion about the extra traversal being fine. I think it would be good t get a review from Stolee as the person who invented "git multi-index-pack repack" and would understand its intended use. Presumably this is all weird "I have a giant Windows repository" packing strategy. :)

-Peff
Previous: Taylor BlauNext: Junio C Hamano
Message 8 of 10 in “midx: use `--stdin-packs` to implement `repack`”
  1. 0/3 midx: use `--stdin-packs` to implement `repack`Taylor Blau, Sep 20, 2022
  2. 1/3 midx.c: compute pack_info array outside of fill_included_packs_batch()Taylor Blau, Sep 20, 2022
  3. 2/3 midx.c: use `pack-objects --stdin-packs` when repackingTaylor Blau, Sep 20, 2022
  4. Derrick StoleeSep 23, 2022
  5. Taylor BlauSep 23, 2022
  6. Derrick StoleeSep 23, 2022
  7. 3/3 midx.c: unify `include_pack` array into `pack_info` structTaylor Blau, Sep 20, 2022
  8. Jeff KingSep 20, 2022
  9. Junio C HamanoSep 21, 2022
  10. Taylor BlauSep 23, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.