Re: [PATCH v2 0/3] midx: use `--stdin-packs` to implement `repack`
- From
Jeff King <peff@peff.net>
- Date
- Sep 20, 2022, 21:54 UTC
- Message-ID
- <Yyo2mJZt6B0JVGwA@coredump.intra.peff.net>
- In-Reply-To
- <cover.1663706401.git.me@ttaylorr.com>
On Tue, Sep 20, 2022 at 04:40:14PM -0400, Taylor Blau wrote:
Show 9 quoted lines
> Here's a few patches that replace the existing "feed each OID > one-by-one" approach to implement the `repack` sub-command of the > `multi-pack-index` builtin with one that uses `pack-objects`'s > `--stdin-packs` option. > > There is an additional patch at the beginning of this series in order to > extract the mtime-sorted list of packs to rollup from their home in > `fill_included_packs_batch()`. There's also one more on the end to unify > the `include_pack` array into the `repack_info` struct(s) themselves.
The first and third make sense to me, and it looks like a nice cleanup.
The middle one looks fine, modulo all of our earlier discussion about the extra traversal being fine. I think it would be good t get a review from Stolee as the person who invented "git multi-index-pack repack" and would understand its intended use. Presumably this is all weird "I have a giant Windows repository" packing strategy. :)
-Peff