Re: [PATCH 1/2] blame: Make --show-name negatable

From: Rene Kita <mail@rkta.de>
Date: Sep 13, 2022, 09:08 UTC
Message-ID: <YyBIfg06kBtuZCmL@t480>
In-Reply-To: <20220913085631.4031-1-walle@fryseskap.localdomain>

On Tue, Sep 13, 2022 at 10:56:31AM +0200, Øystein Walle wrote:

Show 8 quoted lines

> Hi, Junio
> 
> > Not clear to this bystander what exactly is going on.  Is the patch
> > Rene relayed is your rough attempt that was incomplete?
> 
> Correct! I am the nice IRC that was mentioned in the cover letter. My
> improved patch is the one in the e-mail you responded to, apart from
> GMail's text wrapping that was unaware of until now.

That's my fault. I saw the corrected patch, but somehow used the old one. Sorry!

Show 5 quoted lines

> > Thanks.  Let's see if we can have an cleaned-up version with tests,
> > then.
> 
> I can send a corrected (and correctly formatted patch) for review,
> optionally with the docs squashed in with Rene's permission.

Of course.

> Maybe Rene would like to take a stab at writing tests? I am in the
> process of moving house and my usual workstation is not exactly
> online, so it'll be a while.

Yes, I can write a test. Will need to investigate, never worked with the code base.