Re: [PATCH] t1800: correct test to handle Cygwin

From: Đoàn Trần Công Danh <congdanhqx@gmail.com>
Date: Sep 2, 2022, 01:55 UTC
Message-ID: <YxFinAJ2NeKiHaS8@danh.dev>
In-Reply-To: <xmqqedwv9c9f.fsf@gitster.g>

On 2022-09-01 11:32:12-0700, Junio C Hamano <gitster@pobox.com> wrote:

Show 12 quoted lines

> In any case, thanks for a fix.  Will queue.
> 
> >  t/t1800-hook.sh | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/t/t1800-hook.sh b/t/t1800-hook.sh
> > index 64096adac7..fae8b2faf9 100755
> > --- a/t/t1800-hook.sh
> > +++ b/t/t1800-hook.sh
> > @@ -159,7 +159,7 @@ test_expect_success 'git hook run a hook with a bad shebang' '
> >  	# TODO: We should emit the same (or at least a more similar)
> >  	# error on Windows and !Windows. See the OS-specific code in

Please also change the comment here too. I'm not sure what should be put in the comment here, though. Maybe on MINGW and other platforms?

Show 6 quoted lines

> >  	# start_command()
> > -	if test_have_prereq !WINDOWS
> > +	if test_have_prereq !MINGW
> >  	then
> >  		cat >expect <<-\EOF
> >  		fatal: cannot run bad-hooks/test-hook: ...

-- 
Danh