Re: What's cooking in git.git (Aug 2022, #08; Wed, 24)

From: Taylor Blau <me@ttaylorr.com>
Date: Aug 25, 2022, 22:21 UTC
Message-ID: <Ywf1zngpKknCmGYl@nand.local>
In-Reply-To: <xmqqa67s5275.fsf@gitster.g>

On Wed, Aug 24, 2022 at 10:20:30PM -0700, Junio C Hamano wrote:

Show 14 quoted lines

> * ac/bitmap-lookup-table (2022-08-14) 6 commits
>  - bitmap-lookup-table: add performance tests for lookup table
>  - pack-bitmap: prepare to read lookup table extension
>  - pack-bitmap-write: learn pack.writeBitmapLookupTable and add tests
>  - pack-bitmap-write.c: write lookup table extension
>  - bitmap: move `get commit positions` code to `bitmap_writer_finish`
>  - Documentation/technical: describe bitmap lookup table extension
>
>  The pack bitmap file gained a bitmap-lookup table to speed up
>  locating the necessary bitmap for a given commit.
>
>  Needs review.
>  cf. <YwOXIE8K0GJRLuDT@nand.local>
>  source: <pull.1266.v6.git.1660496112.gitgitgadget@gmail.com>

I took a careful look at the latest version of this series (v6) and was happy with the results. My review is here:

    https://lore.kernel.org/git/Ywf01YqJKNsGfffx@nand.local

and I think that this is ready to start cooking in next. Well done, Abhradeep!

Show 15 quoted lines

> * tb/midx-with-changing-preferred-pack-fix (2022-08-22) 7 commits
>  - midx.c: avoid adding preferred objects twice
>  - midx.c: include preferred pack correctly with existing MIDX
>  - midx.c: extract `midx_fanout_add_pack_fanout()`
>  - midx.c: extract `midx_fanout_add_midx_fanout()`
>  - midx.c: extract `struct midx_fanout`
>  - t/lib-bitmap.sh: avoid silencing stderr
>  - t5326: demonstrate potential bitmap corruption
>
>  Multi-pack index got corrupted when preferred pack changed from one
>  pack to another in a certain way, which has been corrected.
>
>  Will merge to 'next'?
>  cf. <be9c7c72-ba24-3e1a-8428-58a2e2afa09a@github.com>
>  source: <cover.1661197803.git.me@ttaylorr.com>

Yeah, this one is ready to go. Stolee gave it a look in the email that you linked, and said it looked good to him.

Abhradeep took a brief look and didn't notice any problems (but I think he is quite busy outside of GSoC right now and so didn't appear to spend a significant amount of time reviewing it).

This should probably be taken to next at the same time or before ac/bitmap-lookup-table, since that topic seems to tickle the bug more often than not.

Show 10 quoted lines

> * tb/show-ref-count (2022-06-06) 2 commits
>  - builtin/show-ref.c: limit output with `--count`
>  - builtin/show-ref.c: rename `found_match` to `matches_nr`
>
>  "git show-ref" learned to stop after emitting N refs with the new
>  "--count=N" option.
>
>  Expecting a reroll.
>  cf. <xmqqczfl4ce1.fsf@gitster.g>
>  source: <cover.1654552560.git.me@ttaylorr.com>

Feel free to discard for now. I put this topic down, and don't think that it's essential to get back to anytime soon-ish.

Thanks, Taylor