git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/3] unused function parameters newly in next

From
Jeff King <peff@peff.net>
Date
Aug 25, 2022, 10:45 UTC
Message-ID
<YwdSzrF3xaHvLsI+@coredump.intra.peff.net>

The sg/parse-options-subcommand topic was merged to 'next', and it introduced a ton of -Wunused-parameter warnings. But I think in this case it revealed some actual bugs, albeit minor.

Here are some fixes. I prepared them on top of that topic, which is semantically necessary. But note that the topic is not itself at fault for _introducing_ any bugs. It just revealed them. So I don't think there's any need to pause its progress to master.

  [1/3]: pass subcommand "prefix" arguments to parse_options()
  [2/3]: maintenance: add parse-options boilerplate for subcommands
  [3/3]: remote: run "remote rm" argv through parse_options()
 builtin/commit-graph.c     |  4 ++--
 builtin/gc.c               | 43 +++++++++++++++++++++++++++++++++++++-
 builtin/multi-pack-index.c |  8 +++----
 builtin/remote.c           | 36 ++++++++++++++++++-------------
 builtin/sparse-checkout.c  |  8 +++----
 5 files changed, 73 insertions(+), 26 deletions(-)
-Peff
Next: Jeff King
Message 1 of 5 in “unused function parameters newly in next”
  1. 0/3 unused function parameters newly in nextJeff King, Aug 25, 2022
  2. 1/3 pass subcommand "prefix" arguments to parse_options()Jeff King, Aug 25, 2022
  3. Junio C HamanoAug 25, 2022
  4. 2/3 maintenance: add parse-options boilerplate for subcommandsJeff King, Aug 25, 2022
  5. 3/3 remote: run "remote rm" argv through parse_options()Jeff King, Aug 25, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.