Re: [PATCH v3 7/7] mergetools: vimdiff: restore selective diff mode

From: Fernando Ramos <greenfoo@u92.eu>
Date: Aug 9, 2022, 05:26 UTC
Message-ID: <YvHv+EcNyHXCNZhK@zacax395.localdomain>
In-Reply-To: <CAMP44s2RsvXnt8LtDcv+Ai_kCxmtURGWXmwfchO08dhjMxkGhA@mail.gmail.com>

On 22/08/08 08:08PM, Felipe Contreras wrote:

Show 5 quoted lines

> 
> Notice that after reorganizing the tab handling my layout becomes really simple:
> 
>   set hidden diffopt-=hiddenoff | silent execute 'bufdo diffthis' | 4b
>

Thanks! I really like this new approach.

I also manually tested your new series (with and without .vimrc) and it works as expected in all listed test cases.

This last series gets the best of both worlds:

  - Highglihting works in single window tabs even when there is just one tab
  
  - Single tab layouts are not treated differently

  - Generates shorter (easier to understand!) vim command strings (nice!)

  - Opens the gate for a future configuration option that lets you enable "all
    buffers diff mode" even if they are not visible in a given tab (maybe this
    could be a new syntax token, *, that "marks" a tab to work in this mode?)

So, definitely a great work. Thanks for the deeper look at the problem and this brilliant solution :)