Re: What's cooking in git.git (Jul 2022, #08; Fri, 29)
- From
Jeff King <peff@peff.net>
- Date
- Jul 31, 2022, 00:29 UTC
- Message-ID
- <YuXM4pmsuDzIqbQT@coredump.intra.peff.net>
- In-Reply-To
- <xmqq7d3v33to.fsf@gitster.g>
On Fri, Jul 29, 2022 at 04:18:59PM -0700, Junio C Hamano wrote:
Show 10 quoted lines
> * jk/struct-zero-init-with-older-gcc (2022-07-29) 1 commit
> - config.mak.dev: squelch -Wno-missing-braces for older gcc
>
> Older gcc with -Wall complains about the universal zero initializer
> "struct s = { 0 };" idiom, which makes developers' lives
> inconvenient (as -Werror is enabled by DEVELOPER=YesPlease). The
> build procedure has been tweaked to help them with thes compilers.
>
> Will merge to 'next'.
> source: <YuQ60ZUPBHAVETD7@coredump.intra.peff.net>If you get a chance before merging, can you please squash in this typo-fix?
diff --git a/config.mak.dev b/config.mak.dev index b9878a4994..4fa19d361b 100644 --- a/config.mak.dev +++ b/config.mak.dev @@ -60,7 +60,7 @@ endif # uninitialized warnings on gcc 4.9.2 in xdiff/xdiffi.c and config.c # not worth fixing since newer compilers correctly stop complaining # -# Likwise, gcc older than 4.9 complains about initializing a +# Likewise, gcc older than 4.9 complains about initializing a # struct-within-a-struct using just "{ 0 }" ifneq ($(filter gcc4,$(COMPILER_FEATURES)),) ifeq ($(filter gcc5,$(COMPILER_FEATURES)),) Thanks. -Peff