Re: [PATCH] merge-file: fix build warning with gcc 4.8.5

From: Jeff King <peff@peff.net>
Date: Jul 30, 2022, 01:40 UTC
Message-ID: <YuSL/2N29cCy9Dzd@coredump.intra.peff.net>
In-Reply-To: <YuR5Jado2LrtZUjP@danh.dev>

On Sat, Jul 30, 2022 at 07:19:49AM +0700, Đoàn Trần Công Danh wrote:

Show 8 quoted lines

> > Tested on a debian jessie chroot using gcc-4.8 and 4.9. Though note that
> > you also need to manually specify -std=gnu99 to get it to work at all
> > with those compilers these days! So I kind of wonder if it's even worth
> > catering to their warnings automatically.
> 
> Well, config.mak.uname automatically adds -std=c99 for RHEL 7 and
> CentOS7. Can we add the same things for Debian? Or should we just
> remove both?

Ah, I didn't know about that. No, I don't think there's any reason to remove them. If people are able to compile out of the box there, then my patch to config.mak.dev may be worth doing.

As far as adding a similar config.mak.uname thing for Debian, I don't have a strong opinion. Jessie is far beyond being supported, so I'd probably wait to see if somebody who actually cares proposes a patch.

-Peff