Re: [PATCH 0/2] mergetools: vimdiff3: fix regression

From: Fernando Ramos <greenfoo@u92.eu>
Date: Aug 6, 2022, 18:29 UTC
Message-ID: <Yu6zEiknXKFMJUVn@zacax395.localdomain>
In-Reply-To: <CAMP44s1uPFGYVJ7dzf1pFXENnUjTTwxHye2iT_HPNiMcmPjD9A@mail.gmail.com>

On 22/08/06 12:53PM, Felipe Contreras wrote:

Show 6 quoted lines

> Two observations though.
> 
> 1. The "silent 4b" is ignored, since bufdo makes the last buffer the
> current buffer, so if you want a different buffer you have to make the
> switch *after* bufdo.
>

Yes, you are right. For the particular case where there are no windows (only hidden buffers) it does not have any effect. It's presence there comes from the fact that the command generation function works in the most "generic" way (ie. producing output that works for all cases: windows, tabs and buffers).

In order not to have another special case in the generation logic I left it there, but you are right in that it is not needed (fortunately it also doesn't make any harm :)

> 2. You probably want to do "set hidden" on all the modes.
>

You are right. It also makes the logic more symmetric. I'll add it.

> I don't see the need for all this complexity for this simple mode, but
> anything that actually works is fine by me.
>

...in fact, back in May I just wanted to add a new "vimdiff4" mode and what originally was a 5 lines patch became the current 1000+ lines patch monster after all the (very welcomed, I'm not complaining!) suggestions :)

I'll reply to this message with a new version of the patch with your "set hidden" suggestion. Thanks!