Re: [PATCH] unpack-objects: fix compilation warning/error due to missing braces

From: Jeff King <peff@peff.net>
Date: Jul 12, 2022, 07:23 UTC
Message-ID: <Ys0hhYjPExuNWynE@coredump.intra.peff.net>
In-Reply-To: <CAPig+cSgNB=SzAZLhXvteSYmy0HvJh+qWHMYyBxcX_EA9__u4A@mail.gmail.com>

On Tue, Jul 12, 2022 at 03:13:50AM -0400, Eric Sunshine wrote:

Show 7 quoted lines

> > Since this is only a warning, and only a practical issue with -Werror I
> > wonder if a config.mak.dev change wouldn't be better, i.e. to provide a
> > -Wno-missing-braces for this older clang version.
> 
> I'm in favor of this. It would, of course, require extra
> special-casing for Apple's clang for which the version number bears no
> resemblance to reality since Apple invents their own version numbers.

I got PTSD reading that thread again, but in case anybody wants to dig into this, I think there are some hints from the last time we discussed this (starting at the end of this message and the subthread):

  https://lore.kernel.org/git/YQ2LdvwEnZN9LUQn@coredump.intra.peff.net/

-Peff