git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] pack-objects.h: remove outdated pahole results

From
Jeff King <peff@peff.net>
Date
Jul 1, 2022, 21:05 UTC
Message-ID
<Yr9hj19gmoiArVat@coredump.intra.peff.net>
In-Reply-To
<Yr9Pg9mRQWe1tgE+@nand.local>
On Fri, Jul 01, 2022 at 03:48:19PM -0400, Taylor Blau wrote:
Show 18 quoted lines
> > I agree the actual numbers aren't helping anybody. We _could_ leave a
> > comment that says "we store a lot of these in memory; be careful of
> > where and how you add new fields to avoid increasing the struct size".
> > And then people can run "pahole" before and after their changes.
> >
> > But then that is also true of other structs (like "struct object"), and
> > we do not bother there. So it probably is fine not to annotate this
> > specifically.
> 
> We have such a comment at the very type of the block comment above
> `struct object_entry`'s definition:
> 
>     "The size of struct nearly determines pack-object's memory
>     consumption. This struct is packed tight for that reason. When you
>     add or reorder something in this struct, think a bit about this".
> 
> thanks to Duy back in 3b13a5f263 (pack-objects: reorder members to
> shrink struct object_entry, 2018-04-14).
Oh, indeed. Then I withdraw my (non-)complaint. :)
-Peff
Previous: Taylor Blau
Message 7 of 7 in “pack-objects.h: remove outdated pahole results”
  1. pack-objects.h: remove outdated pahole resultsTaylor Blau, Jun 28, 2022
  2. Derrick StoleeJun 28, 2022
  3. brian m. carlsonJun 28, 2022
  4. Taylor BlauJun 28, 2022
  5. Jeff KingJul 1, 2022
  6. Taylor BlauJul 1, 2022
  7. Jeff KingJul 1, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.