Re: [PATCH v3 1/4] cocci: add and apply a rule to find "unused" strbufs
- From
Jeff King <peff@peff.net>
- Date
- Jul 1, 2022, 18:04 UTC
- Message-ID
- <Yr83SjgGMMwN0r0s@coredump.intra.peff.net>
- In-Reply-To
- <patch-v3-1.4-49e9ccb5819-20220701T102506Z-avarab@gmail.com>
On Fri, Jul 01, 2022 at 12:30:56PM +0200, Ævar Arnfjörð Bjarmason wrote:
> The use of "with strict" here will be explained and amended in the > following commit.
Really s/the following/a following/ now that there's another commit in between. :)
I didn't find the comment there very enlightening, though. It says we're dropping "with strict" to catch some new cases around early returns. But it's not clear to me what "strict" does in the first place, why we'd want it, or what we might be losing by dropping it.
I know, I can probably go read the coccinelle docs to figure it out, but it might be worth saying why it's worth including in the first place somewhere (either here or in the follow-up commit).
-Peff