Re: [Internet]Re: [PATCH v2] send-pack.c: add config push.useBitmaps

From: Taylor Blau <me@ttaylorr.com>
Date: Jun 16, 2022, 21:17 UTC
Message-ID: <Yqud+Y6LgkbmBOBj@nand.local>
In-Reply-To: <be5afab25a5b44b3af797c0c8b75f5e6@tencent.com>

On Thu, Jun 16, 2022 at 03:11:09PM +0000, kylezhao(赵柯宇) wrote:

Show 9 quoted lines

> > At the time I didn't, because as noted in a follow-up I'd lost my test
> > case by the time I read that, but it seems you haven't, and have a
> > current test case.
>
> I tried to find a test case in open-source projects, and finally found one.
> $ git clone https://github.com/JetBrains/intellij-community.git --bare
> $ cd intellij-community.git
> $ git repack -adb
> $ GIT_TRACE=1 git push . master:test1

I wouldn't expect this to push any objects at all, since you're pushing to a repository that already has all of the objects contained in `master`.

A more representative test might be something like:

    $ git clone https://github.com/JetBrains/intellij-community.git --bare
    $ cd intellij-community.git
    $ git repack -adb
    $ git rev-parse HEAD >in
    $ time git pack-objects --revs --stdout <in >/dev/null
    # move the bitmap away so we don't use it
    $ mv objects/pack/pack-*.bitmap{,.bak}
    $ time git pack-objects --revs --stdout <in >/dev/null

Thanks, Taylor