git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] commit-graph: refactor to avoid prepare_repo_settings

From
Taylor Blau <me@ttaylorr.com>
Date
Jun 14, 2022, 23:32 UTC
Message-ID
<YqkamW45+VbIfJI4@nand.local>
In-Reply-To
<9b56496b0809cc8a25af877ea97042e2cb7f2af6.1655246092.git.steadmon@google.com>
On Tue, Jun 14, 2022 at 03:37:21PM -0700, Josh Steadmon wrote:
Show 15 quoted lines
> Range-diff against v2:
> 1:  2c2bfc7b43 ! 1:  9b56496b08 commit-graph: refactor to avoid prepare_repo_settings
>     @@ fuzz-commit-graph.c: int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size
>       	initialize_the_repository();
>      -	g = parse_commit_graph(the_repository, (void *)data, size);
>      +	/*
>     -+	 * Manually initialize commit-graph settings, to avoid the need to run
>     -+	 * in an actual repository.
>     ++	 * Initialize the_repository with commit-graph settings that would
>     ++	 * normally be read from the repository's gitdir. We want to avoid
>     ++	 * touching the disk to keep the individual fuzz-test cases as fast as
>     ++	 * possible.
>      +	 */
>      +	the_repository->settings.commit_graph_generation_version = 2;
>      +	the_repository->settings.commit_graph_read_changed_paths = 1;
This version looks good to me. Thanks for working on this, Josh!

Thanks, Taylor

Previous: Josh SteadmonNext: Junio C Hamano
Message 19 of 27 in “repo-settings: set defaults even when not in a repo”
  1. repo-settings: set defaults even when not in a repoJosh Steadmon, Mar 23, 2022
  2. Derrick StoleeMar 23, 2022
  3. Taylor BlauMar 23, 2022
  4. Josh SteadmonMar 28, 2022
  5. Taylor BlauMar 29, 2022
  6. Josh SteadmonMar 28, 2022
  7. Taylor BlauMar 29, 2022
  8. Ævar Arnfjörð BjarmasonMar 29, 2022
  9. Taylor BlauMar 30, 2022
  10. Josh SteadmonApr 9, 2022
  11. Ævar Arnfjörð BjarmasonMar 29, 2022
  12. Taylor BlauMar 30, 2022
  13. Ævar Arnfjörð BjarmasonMar 30, 2022
  14. Junio C HamanoMar 30, 2022
  15. commit-graph: refactor to avoid prepare_repo_settingsJosh Steadmon, Apr 9, 2022
  16. Jonathan TanJun 7, 2022
  17. Josh SteadmonJun 14, 2022
  18. commit-graph: refactor to avoid prepare_repo_settingsJosh Steadmon, Jun 14, 2022
  19. Taylor BlauJun 14, 2022
  20. Junio C HamanoJun 23, 2022
  21. Josh SteadmonJul 14, 2022
  22. commit-graph: pass repo_settings instead of repositoryJosh Steadmon, Jul 14, 2022
  23. Junio C HamanoJul 14, 2022
  24. Victoria DyeMar 23, 2022
  25. Junio C HamanoMar 23, 2022
  26. Victoria DyeMar 23, 2022
  27. Junio C HamanoMar 23, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.