Re: [RFC PATCH 0/3] trace2: log "signal" end events if we invoke BUG()

From: Josh Steadmon <steadmon@google.com>
Date: May 31, 2022, 17:59 UTC
Message-ID: <YpZXj/VzMTNPSA1H@google.com>
In-Reply-To: <xmqq8rqp3x9z.fsf@gitster.g>

On 2022.05.25 18:20, Junio C Hamano wrote:

Show 11 quoted lines

> Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:
> 
> > (depending on the TZ) that he'd encountered trace2 event streams
> > without an "exit" event, which as discussed can be seen from usage.c
> > is due to our invoking of abort() there.
> 
> Josh, is this related to the "in rare cases" thing we discussed on
> the "run-command: don't spam trace2_child_exit()" thread?
> 
> https://lore.kernel.org/git/4616d09ffa632bd2c9e308a713c4bdf2a1328c3c.1651179450.git.steadmon@google.com/
>

No, this is a much more frequent issue than the repeated "child_exit" events from that thread. Any time Git exits without calling our exit() wrapper, we don't log any "exit" events (and presumably skip "atexit" as well).