git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Crashes in t/t4058-diff-duplicates.sh

From
Taylor Blau <me@ttaylorr.com>
Date
May 9, 2022, 15:23 UTC
Message-ID
<Ynkx/nI67uOUDhL9@nand.local>
In-Reply-To
<CABPp-BEb8saqS0awK77y+-3oB1LAOPwOw-2dZU=67wJOKLBS1Q@mail.gmail.com>
On Fri, May 06, 2022 at 09:14:07PM -0700, Elijah Newren wrote:
Show 10 quoted lines
> > That commit talks about "trees with duplicate entries".  Does it
> > mean a bad history where a tree object has two or more entries under
> > the same name?
>
> Yes.
>
> > We should of course be catching these things at fsck
> > time and rejecting at network transfer time, but I agree it is not a
> > good excuse for us to segfault.  We should diagnose it as a broken
> > tree object and actively refuse to proceed by calling die().

Elijah would be able to comment more authoritatively than I could about whether or not these are easily detect-able. If they are, then I think it'd be worth doing so and calling die(). But they may be tricker, I don't know.

Thanks, Taylor

Previous: Elijah NewrenNext: Elijah Newren
Message 5 of 7 in “Crashes in t/t4058-diff-duplicates.sh”
  1. Alex RiesenMay 5, 2022
  2. Alex RiesenMay 6, 2022
  3. Junio C HamanoMay 6, 2022
  4. Elijah NewrenMay 7, 2022
  5. Taylor BlauMay 9, 2022
  6. Elijah NewrenMay 10, 2022
  7. Alex RiesenMay 9, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.