git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: reference-transaction regression in 2.36.0-rc1

From
Patrick Steinhardt <ps@pks.im>
Date
Apr 27, 2022, 11:05 UTC
Message-ID
<YmkjfyB3gIQ2t45V@ncase>
In-Reply-To
<CAJDSCnOUQm-doY-xTobPk64oeiSsTd+vSFzsb_cz9BLORAxXGA@mail.gmail.com>

Thanks a lot to all of you for handling this regression while I was out of office!

On Tue, Apr 19, 2022 at 11:54:19AM +0200, Michael Heemskerk wrote:
Show 18 quoted lines
> Apologies for the late reply. Bryan had his last day at Atlassian last
> week, so I'll take over from him on this topic.
> 
> Thanks for asking this question, which is lot more urgent and I
> > should have asked last night before I went to bed.  Yes, Bryan
> > already said that the revert in 'seen' the previous day made their
> > system happier, but it certainly helps to know the reverts were OK
> > at the tip of 'master' without all the other random topics.
> >
> 
> I have run all our tests on the tip of master prior to 2.36 being released,
>  and on the released 2.36. Our tests are happy on both, so thanks for
>  reverting those reference-transaction changes for 2.36.
> 
> I'd be happy to provide the fix to files_delete_refs in a patch (including
> some extra tests) on top of Patrick's
> avoid-unnecessary-hook-invocation-with-packed-refs series if and
> when that series is unreverted on 'next'.

That would be great. To be clear, do the fixes you have also fix the pre-v2.36.0 issues Bryan has mentioned?

Please let me know whether you want to pursue this and whether you need any further help with it.

Patrick
Previous: Junio C HamanoNext: Patrick Steinhardt
Message 13 of 14 in “reference-transaction regression in 2.36.0-rc1”
  1. Bryan TurnerApr 12, 2022
  2. Bryan TurnerApr 12, 2022
  3. Ævar Arnfjörð BjarmasonApr 13, 2022
  4. René ScharfeApr 13, 2022
  5. Junio C HamanoApr 13, 2022
  6. Junio C HamanoApr 13, 2022
  7. Bryan TurnerApr 13, 2022
  8. Junio C HamanoApr 13, 2022
  9. Junio C HamanoApr 13, 2022
  10. Bryan TurnerApr 15, 2022
  11. Ævar Arnfjörð BjarmasonApr 15, 2022
  12. Junio C HamanoApr 15, 2022
  13. Patrick SteinhardtApr 27, 2022
  14. Patrick SteinhardtMay 2, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.