Re: [ANNOUNCE] Git v2.36.0-rc0 - Build failure on NonStops

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Apr 5, 2022, 08:10 UTC
Message-ID: <Ykv5dCEv/gl7aHMq@camp.crustytoothpaste.net>
In-Reply-To: <20220405042826.56vyilttx3lo4scv@carlos-mbp.lan>

On 2022-04-05 at 04:28:26, Carlo Marcelo Arenas Belón wrote:

Show 15 quoted lines

> Subject: [PATCH] git-compat-util: really support openssl as a source of entropy
> 
> 05cd988dce5 (wrapper: add a helper to generate numbers from a CSPRNG,
> 2022-01-17), configure openssl as the source for entropy in NON-STOP
> but doesn't add the needed header or link options.
> 
> Since the only system that is configured to use openssl as a source
> of entropy is NON-STOP, add the header unconditionally, and -lcrypto
> to the list of external libraries.
> 
> An additional change is required to make sure a NO_OPENSSL=1 build
> will be able to work as well (tested on Linux with a modified value
> of CSPRNG_METHOD = openssl), and the more complex logic that allows
> for compatibility with APPLE_COMMON_CRYPTO or allowing for simpler
> ways to link (without libssl) has been punted for now.

I didn't consider the case that we had NO_OPENSSL=1 because it seems a bit bizarre to say, "No, I don't want OpenSSL—oh, wait, I do want OpenSSL!"

This patch also didn't seem necessary for me on Linux when I tested, but of course it might be necessary on some systems, so if it fixes things, I'm in favour.

-- 
brian m. carlson (he/him or they/them)
Toronto, Ontario, CA